[webkit-reviews] review denied: [Bug 90055] Fix gcc build after r121302 : [Attachment 149700] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 90055: Fix gcc build after r121302
https://bugs.webkit.org/show_bug.cgi?id=90055

Attachment 149700: Patch
https://bugs.webkit.org/attachment.cgi?id=149700&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149700&action=review


> Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h:349
> +#elif defined(__clang__) || defined(__llvm__) // Assume RTTO is always
enabled on LLVM
> +
> +#define GTEST_HAS_RTTI 1
> +

It's not correct to assume that RTTI is enabled. Doing this will break the
clang build in the same way that GCC is currently broken.