[webkit-reviews] review denied: [Bug 89889] Web Inspector: replace recursion with a stack in DOM nodes snapshot traversal. : [Attachment 149536] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 89889: Web Inspector: replace recursion with a stack in DOM nodes snapshot
traversal.
https://bugs.webkit.org/show_bug.cgi?id=89889

Attachment 149536: Patch
https://bugs.webkit.org/attachment.cgi?id=149536&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149536&action=review


> Source/WebCore/dom/MemoryInstrumentation.h:120
> +class MemoryInstrumentedPointerBase {

I'd move these classes into MemoryInstrumentation as they are just
implementation details. It would also allow us to give them shorter names.

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:476
> +    Vector<PassOwnPtr<MemoryInstrumentedPointerBase> >
m_deferredInstrumentedPointers;

PassOwnPtr is supposed to be used for passing objects ownership only, you
should use Vector<OwnPtr<...> > here.