[webkit-reviews] review granted: [Bug 90043] [V8] Optimize Integer::New() by caching persistent handles for small integers : [Attachment 149687] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 90043: [V8] Optimize Integer::New() by caching persistent handles for small
integers
https://bugs.webkit.org/show_bug.cgi?id=90043

Attachment 149687: Patch
https://bugs.webkit.org/attachment.cgi?id=149687&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149687&action=review


I think this is fine, but you might want to check with folks who understand
Dispose better than I do.

> Source/WebCore/bindings/v8/V8Binding.h:92
> +    const int NumberOfCachedSmallIntegers = 64;

nit: NumberOfCachedSmallIntegers -> numberOfCachedSmallIntegers