[webkit-reviews] review granted: [Bug 87503] [Gtk] Add support for the Gamepad API : [Attachment 149310] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 87503: [Gtk] Add support for the Gamepad API
https://bugs.webkit.org/show_bug.cgi?id=87503

Attachment 149310: Patch
https://bugs.webkit.org/attachment.cgi?id=149310&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149310&action=review


Great!

> Source/WebCore/platform/gtk/GamepadsGtk.cpp:86
> +    // FIXME: Properly log the error.

Are you going to fix this in a follow up patch?

> Source/WebCore/platform/linux/GamepadDeviceLinux.cpp:43
> +    // FIXME: Log errors when returning early.

Ditto.

> Tools/Scripts/webkitperl/FeatureList.pm:217
> -	 define => "ENABLE_GAMEPAD", default => 0, value => \$gamepadSupport },

> +	 define => "ENABLE_GAMEPAD", default => isGtk(), value =>
\$gamepadSupport },

Should we change the default in configure as well?