[webkit-reviews] review denied: [Bug 89569] pattern="" should only accept the empty string : [Attachment 149638] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 17:57:43 PDT 2012


Darin Adler <darin at apple.com> has denied Pablo Flouret <pablof at motorola.com>'s
request for review:
Bug 89569: pattern="" should only accept the empty string
https://bugs.webkit.org/show_bug.cgi?id=89569

Attachment 149638: Patch
https://bugs.webkit.org/attachment.cgi?id=149638&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149638&action=review


Good fix. Need to do it slightly differently, though.

> Source/WebCore/html/BaseTextInputType.cpp:44
> -    if (rawPattern.isEmpty() || value.isEmpty())
> +    if (!element()->fastHasAttribute(patternAttr) || value.isEmpty())

The correct way to check this is:

    if (rawPattern.isNull() || value.isEmpty())

There’s no need for a fastHasAttribute call, which will do another attribute
hash table lookup.


More information about the webkit-reviews mailing list