[webkit-reviews] review requested: [Bug 90024] Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test : [Attachment 149625] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 16:28:33 PDT 2012


Darin Adler <darin at apple.com> has asked  for review:
Bug 90024: Convert editing/inserting/font-size-clears-from-typing-style.html to
a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=90024

Attachment 149625: Patch
https://bugs.webkit.org/attachment.cgi?id=149625&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149625&action=review


> LayoutTests/ChangeLog:8
> +	   Converted a script test to a dump-as-markup test because the test
result can be understood much eaiser that way.

Unfortunately this test no longer states what the expected result is. That’s a
step backwards. Before the test would say PASS or FAIL. Now it just dumps out a
tree and you have to know what the expected result is.


More information about the webkit-reviews mailing list