[webkit-reviews] review granted: [Bug 89979] [Chromium] Tests still crashing for Linux Release as well. : [Attachment 149529] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted mstarzinger at chromium.org's request
for review:
Bug 89979: [Chromium] Tests still crashing for Linux Release as well.
https://bugs.webkit.org/show_bug.cgi?id=89979

Attachment 149529: Patch
https://bugs.webkit.org/attachment.cgi?id=149529&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149529&action=review


You might want to coordinate with the webkit gardener rather than going through
a full code review for this type of change.

> LayoutTests/platform/chromium/TestExpectations:3422
>  BUGCR121442 LINUX DEBUG : plugins/iframe-shims.html = CRASH
> +BUGCR121442 LINUX RELEASE : plugins/iframe-shims.html = PASS CRASH

Does the test sometimes pass? It would be good to have that information as a
comment on the bug, e.g., a link to the flakiness dashboard.  A stack trace on
the bug is also useful).