[webkit-reviews] review granted: [Bug 89759] [CSSRegions]Change display values that allow regions : [Attachment 149492] patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Andrei Onea <onea at adobe.com>'s
request for review:
Bug 89759: [CSSRegions]Change display values that allow regions
https://bugs.webkit.org/show_bug.cgi?id=89759

Attachment 149492: patch
https://bugs.webkit.org/attachment.cgi?id=149492&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149492&action=review


> LayoutTests/fast/regions/script-tests/region-element-display-change.js:26
> +shouldBeFalse('testElement(element, "inline-table")');
> +shouldBeTrue('testElement(element, "table-cell")');
> +shouldBeTrue('testElement(element, "table-caption")');
> +shouldBeTrue('testElement(element, "list-item")');

Nit: I would go ahead and add all the other display types here.

> Source/WebCore/rendering/RenderObject.cpp:154
> +    if (doc->cssRegionsEnabled() && style->isDisplayRegionType() &&
!style->regionThread().isEmpty() && doc->renderView())
> +	   return new (arena) RenderRegion(node,
doc->renderView()->flowThreadController()->ensureRenderFlowThreadWithName(style
->regionThread()));

Please watch the perf results at http://webkit-perf.appspot.com/ after this
lands. I don't expect there to be a regression, but it's good to be ready.