[webkit-reviews] review granted: [Bug 89959] Change return type in bandwidth attribute of network information API : [Attachment 149486] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 11:05:45 PDT 2012


Adam Barth <abarth at webkit.org> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 89959: Change return type in bandwidth attribute of network information API
https://bugs.webkit.org/show_bug.cgi?id=89959

Attachment 149486: Patch
https://bugs.webkit.org/attachment.cgi?id=149486&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149486&action=review


> Source/WebKit/efl/WebCoreSupport/NetworkInfoClientEfl.cpp:95
> -    return bandwidth / 8; // MB/s
> +    return static_cast<double>(bandwidth / 8); // MB/s

This static_cast shouldn't be needed.


More information about the webkit-reviews mailing list