[webkit-reviews] review granted: [Bug 17767] frameborder="no" on frameset is ignored if border attribute set : [Attachment 149410] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Elliott Sprehn <esprehn at gmail.com>'s
request for review:
Bug 17767: frameborder="no" on frameset is ignored if border attribute set
https://bugs.webkit.org/show_bug.cgi?id=17767

Attachment 149410: Patch
https://bugs.webkit.org/attachment.cgi?id=149410&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149410&action=review


> LayoutTests/fast/frames/frame-frameborder-overides-border.html:5
> +    WebKit doesn't ignore border="..." when frameborder is NO while all
other
> +    browsers will.

I would probably use a dumpAsText test instead.  It's slightly easier to
maintain than a reftest.  Also, for dumpAsText or reftests, I would include the
description text in the generated output.  It might also be nice to add tests
for frameborder={0,1,yes}.