[webkit-reviews] review granted: [Bug 89478] [REGRESSION] [Chromium] keydown/keyup events are broken for all paired modifier keys : [Attachment 148540] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 89478: [REGRESSION] [Chromium] keydown/keyup events are broken for all
paired modifier keys
https://bugs.webkit.org/show_bug.cgi?id=89478

Attachment 148540: Patch
https://bugs.webkit.org/attachment.cgi?id=148540&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148540&action=review


> LayoutTests/fast/events/keydown-leftright-keys.html:55
> -    testKeyEventWithLocation("leftShift", VK_SHIFT, "KEY_LOCATION_LEFT");
> -    testKeyEventWithLocation("leftControl", VK_CONTROL,
"KEY_LOCATION_LEFT");
> -    testKeyEventWithLocation("leftAlt", VK_MENU, "KEY_LOCATION_LEFT");
> +    testKeyEventWithLocation("leftShift", VK_SHIFT, "KEY_LOCATION_LEFT",
"Shift");
> +    testKeyEventWithLocation("leftControl", VK_CONTROL, "KEY_LOCATION_LEFT",
"Control");
> +    testKeyEventWithLocation("leftAlt", VK_MENU, "KEY_LOCATION_LEFT",
"Alt");
>  
> -    testKeyEventWithLocation("rightShift", VK_SHIFT, "KEY_LOCATION_RIGHT");
> -    testKeyEventWithLocation("rightControl", VK_CONTROL,
"KEY_LOCATION_RIGHT");
> -    testKeyEventWithLocation("rightAlt", VK_MENU, "KEY_LOCATION_RIGHT");
> +    testKeyEventWithLocation("rightShift", VK_SHIFT, "KEY_LOCATION_RIGHT",
"Shift");
> +    testKeyEventWithLocation("rightControl", VK_CONTROL,
"KEY_LOCATION_RIGHT", "Control");
> +    testKeyEventWithLocation("rightAlt", VK_MENU, "KEY_LOCATION_RIGHT",
"Alt");

Does this pass on Mac, GTK+, Qt, etc...?