[webkit-reviews] review denied: [Bug 89889] Web Inspector: replace recursion with a stack in DOM nodes snapshot traversal. : [Attachment 149315] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 89889: Web Inspector: replace recursion with a stack in DOM nodes snapshot
traversal.
https://bugs.webkit.org/show_bug.cgi?id=89889

Attachment 149315: Patch
https://bugs.webkit.org/attachment.cgi?id=149315&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149315&action=review


> Source/WebCore/dom/MemoryInstrumentation.h:40
> +class MemoryInstrumentedPointerBase;

Forward declarations should go in alphabetic order.

> Source/WebCore/dom/MemoryInstrumentation.h:111
> +    void countObjectSize()

Please inline this method instead.

> Source/WebCore/dom/MemoryInstrumentation.h:134
> +    void processInstrumentedPointer(MemoryInstrumentation*
memoryInstrumentation)

missing virtual and OVERRIDE

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:451
> +	       delete pointer;

Please use queue of OwnPtr's to avoid manual delete.

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:475
> +    Vector<MemoryInstrumentedPointerBase*> m_worklist;

m_instrumentedPointers?