[webkit-reviews] review requested: [Bug 89872] [WK2] Add new C API to generate MHTML data from the UI process : [Attachment 149472] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 89872: [WK2] Add new C API to generate MHTML data from the UI process
https://bugs.webkit.org/show_bug.cgi?id=89872

Attachment 149472: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=149472&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #6)
> (From update of attachment 149289 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=149289&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPage.cpp:602
> > +	 WKPageGetContentsAsMHTMLData(pageRef,
callGetContentsAsMHTMLDataBlockAndDispose, Block_copy(block));
> 
> You are missing the bool useBinaryEncoding parameter here. And the order is
context, callback, you are passing the callback before the context.

Ah! That explains things. Attaching a new patch