[webkit-reviews] review denied: [Bug 89872] [WK2] Add new C API to generate MHTML data from the UI process : [Attachment 149289] Patch proposal

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 89872: [WK2] Add new C API to generate MHTML data from the UI process
https://bugs.webkit.org/show_bug.cgi?id=89872

Attachment 149289: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=149289&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149289&action=review


> Source/WebKit2/UIProcess/API/C/WKPage.cpp:602
> +    WKPageGetContentsAsMHTMLData(pageRef,
callGetContentsAsMHTMLDataBlockAndDispose, Block_copy(block));

You are missing the bool useBinaryEncoding parameter here. And the order is
context, callback, you are passing the callback before the context.