[webkit-reviews] review denied: [Bug 88631] [EFL][WK2] Add ewk_view_touchscreen which has touchscreen behavior. : [Attachment 147743] Patch for ewk_view_touchscreen.

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 88631: [EFL][WK2] Add ewk_view_touchscreen which has touchscreen behavior.
https://bugs.webkit.org/show_bug.cgi?id=88631

Attachment 147743: Patch for ewk_view_touchscreen.
https://bugs.webkit.org/attachment.cgi?id=147743&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147743&action=review


Set '-' because above comments.

> Source/WebKit2/UIProcess/API/efl/ewk_view_touchscreen.cpp:29
> +using namespace WebCore;

I wonder why do you add WebCore namespace. I can't find WebCore usage in this
file.

> Source/WebKit2/UIProcess/API/efl/ewk_view_touchscreen.cpp:31
> +static Ewk_View_Smart_Class g_parentSmartClass =
EWK_VIEW_SMART_CLASS_INIT_NULL;

g_ is GTK port style. Please keep to consistent with WK1 EFL style.