[webkit-reviews] review granted: [Bug 89931] [chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements : [Attachment 149413] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 89931: [chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements
https://bugs.webkit.org/show_bug.cgi?id=89931

Attachment 149413: Patch
https://bugs.webkit.org/attachment.cgi?id=149413&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Thanks for fixing this - we've had some real bugs due to this in the past, I
believe.

We should probably add a style check for this - could you file a bug to track
that? (Tools/Scripts/webkitpy/style/checkers/cpp.py if you're feeling super
ambitious :) ).