[webkit-reviews] review granted: [Bug 89700] [chromium] Use WebGraphicsContext3D in compositor implementation : [Attachment 149203] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 89700: [chromium] Use WebGraphicsContext3D in compositor implementation
https://bugs.webkit.org/show_bug.cgi?id=89700

Attachment 149203: Patch
https://bugs.webkit.org/attachment.cgi?id=149203&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149203&action=review


I feel like I should have more substantial comments on a 186k patch, but R=me.

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:1365
> -    RefPtr<CCGraphicsContext> ccContext =
CCGraphicsContext::create3D(m_context);
> -    texture->framebufferTexture2D(ccContext.get(),
m_implTextureAllocator.get());
> +    if (!texture->textureId())
> +	   texture->allocate(m_implTextureAllocator.get());
> +    GLC(m_context,
m_context->framebufferTexture2D(GraphicsContext3D::FRAMEBUFFER,
GraphicsContext3D::COLOR_ATTACHMENT0, GraphicsContext3D::TEXTURE_2D,
texture->textureId(), 0));

Can the ManagedTexture::framebufferTexture2d and bindTexture functions get
removed?