[webkit-reviews] review granted: [Bug 78109] [Qt] Make it possible to build WebKit without QtWidgets : [Attachment 149323] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 78109: [Qt] Make it possible to build WebKit without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=78109

Attachment 149323: Patch
https://bugs.webkit.org/attachment.cgi?id=149323&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149323&action=review


r=me with a few minor nitpicks

> Source/api.pri:141
>      QMAKE_INTERNAL_INCLUDED_FILES *= WebKit2/Target.pri

You need the same hack for WebKit1.pri

> Tools/qmake/mkspecs/features/default_pre.prf:108
> +	   root_project_file: error("Building WebKit against Qt 5.0 requires
the QtWidgets and QtPrintSupport modules. Disabling WebKit1.")

This is no longer a fatal error and should use warning instead of error. The
message could also reflect this, eg, "WebKit1 requires the QtWidgets and
QtPrintSupport modules. Disabling WebKit1."