[webkit-reviews] review granted: [Bug 71859] MHTML documents containing references to resources they don't include never finish loading : [Attachment 146168] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 71859: MHTML documents containing references to resources they don't
include never finish loading
https://bugs.webkit.org/show_bug.cgi?id=71859

Attachment 146168: Patch
https://bugs.webkit.org/attachment.cgi?id=146168&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146168&action=review


> Source/WebCore/loader/DocumentLoader.cpp:694
> +	   // Schedule this loader without a resource so that resource
completion/failure notifications are still fired.
> +	   m_pendingSubstituteResources.set(loader, 0);
> +	   deliverSubstituteResourcesAfterDelay();

It might make sense to be a little more explicit here that didFail() will get
called via substituteResourceDeliveryTimerFired() for a null
SubstituteResource. It wasn't immediately obvious to me that this was safe.