[webkit-reviews] review denied: [Bug 89779] [BlackBerry] Add JSC statistics into about:memory : [Attachment 149328] the patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Yong Li <yoli at rim.com>'s request for
review:
Bug 89779: [BlackBerry] Add JSC statistics into about:memory
https://bugs.webkit.org/show_bug.cgi?id=89779

Attachment 149328: the patch
https://bugs.webkit.org/attachment.cgi?id=149328&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149328&action=review


Some typos still.

> Source/JavaScriptCore/PlatformBlackBerry.cmake:13
> +IF (NOT DEFINED PUBLIC_BIULD OR NOT PUBLIC_BIULD)

Tyop?

> Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:247
> +    page += "<h2>JS engnine memory usage</h2><table align=\"center\"
rules=\"all\">";

engine

> Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:256
> +    page += numberToHTMLTr("Protected gloal object count",
mainHeap.protectedGlobalObjectCount());

global