[webkit-reviews] review denied: [Bug 89892] Compilation failure in StyleResolver.cpp (clang) : [Attachment 149317] Patch

[bugzilla-daemon at webkit.org]

Alexis Menard (darktears) <alexis.menard at openbossa.org> has denied Mike West
<mkwst at chromium.org>'s request for review:
Bug 89892: Compilation failure in StyleResolver.cpp (clang)
https://bugs.webkit.org/show_bug.cgi?id=89892

Attachment 149317: Patch
https://bugs.webkit.org/attachment.cgi?id=149317&action=review

------- Additional Comments from Alexis Menard (darktears)
<alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149317&action=review


> Source/WebCore/css/CSSParser.cpp:2634
> +#endif

It is misleading to put it there as per comment above : 

// These properties should be handled before in
isValidKeywordPropertyAndValue().

And CSSPropertyVariable is not handled there. So it will ASSERT which is
incorrect.

You better make a case somewhere else, and return false, add a FIXME :
Implement me.

> Source/WebCore/css/StyleResolver.cpp:4281
> +#endif

Ditto there. Incorrect.