[webkit-reviews] review denied: [Bug 87610] The eventSender.beginDragWithFiles had been implemented in windows, related tests listed in LayoutTests/platform/win/Skipped should be rebaselined : [Attachment 149189] patch

[bugzilla-daemon at webkit.org]

Jessie Berlin <jberlin at webkit.org> has denied huangxueqing
<huangxueqing at baidu.com>'s request for review:
Bug 87610: The eventSender.beginDragWithFiles had been implemented in windows,
related tests listed in LayoutTests/platform/win/Skipped should be rebaselined
https://bugs.webkit.org/show_bug.cgi?id=87610

Attachment 149189: patch
https://bugs.webkit.org/attachment.cgi?id=149189&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149189&action=review


> LayoutTests/platform/win/Skipped:260
>  http/tests/security/clipboard/clipboard-file-access.html

It is wrong to leave all these other tests that still fail under the "#
<rdar://problem/5230396> eventSender.beginDragWithFiles is unimplemented" -
that makes it appear as if you haven't fixed this bug and hides the other
issues you have identified.

You have already done the great work to identify the reason these tests
continue to fail - please represent that in the Skipped file.

For instance, fast/forms/file/input-file-directory-upload.html is already in
the Skipped list in another section "# Directory upload is not enabled.", so
you can just remove it from this list. For those that don't already have
sections in the Skipped list, you can add sections for them.

You should be able to totally remove "# <rdar://problem/5230396>
eventSender.beginDragWithFiles is unimplemented" section as part of this patch.