[webkit-reviews] review denied: [Bug 89244] Web Inspector: Add data length to resource events on timeline to keep track of the amount of data loaded and the total data length : [Attachment 149294] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Hanna <hanma at rim.com>'s
request for review:
Bug 89244: Web Inspector: Add data length to resource events on timeline to
keep track of the amount of data loaded and the total data length
https://bugs.webkit.org/show_bug.cgi?id=89244

Attachment 149294: Patch
https://bugs.webkit.org/attachment.cgi?id=149294&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149294&action=review


> LayoutTests/inspector/timeline/timeline-network-received-data-expected.txt:4
> +ResourceReceivedData Properties:

Your test is fetching the script from the given URL and expects single received
data entry here. Whereas the data can be sent in a number of chunks. You should
change your test so that it makes sure that _at least one_ data chunk is
received.