[webkit-reviews] review granted: [Bug 89857] [BlackBerry] Fill more data in device motion event : [Attachment 149257] Patch v3

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 89857: [BlackBerry] Fill more data in device motion event
https://bugs.webkit.org/show_bug.cgi?id=89857

Attachment 149257: Patch v3
https://bugs.webkit.org/attachment.cgi?id=149257&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149257&action=review


> Source/WebKit/blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp:81
> +    RefPtr<DeviceMotionData::Acceleration> acceleration =
DeviceMotionData::Acceleration::create(
> +	   true, event->acceleration.x, true, event->acceleration.y, true,
event->acceleration.z);
> +
> +    RefPtr<DeviceMotionData::Acceleration> accelerationIncludingGravity =
DeviceMotionData::Acceleration::create(
> +	   true, event->accelerationIncludingGravity.x, true,
event->accelerationIncludingGravity.y, true,
event->accelerationIncludingGravity.z);
> +
> +    RefPtr<DeviceMotionData::RotationRate> rotationRate =
DeviceMotionData::RotationRate::create(
> +	   true, event->rotationRate.alpha, true, event->rotationRate.beta,
true, event->rotationRate.gamma);

please add comments to clarify what the boolean parameters are.