[webkit-reviews] review denied: [Bug 88420] Web Inspector: Provide source data for all known rule types in CSSParser, except "keyframe" and "region" : [Attachment 149301] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 25 09:52:05 PDT 2012
Vsevolod Vlasov <vsevik at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 88420: Web Inspector: Provide source data for all known rule types in
CSSParser, except "keyframe" and "region"
https://bugs.webkit.org/show_bug.cgi?id=88420
Attachment 149301: Patch
https://bugs.webkit.org/attachment.cgi?id=149301&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149301&action=review
> Source/WebCore/css/CSSParser.cpp:9339
> +void CSSParser::updateTopRuleBodyEnd()
Could this be replaced by markRuleBodyEnd?
> Source/WebCore/css/CSSParser.cpp:9344
> + if (m_currentRuleDataStack->isEmpty())
The stack is never empty at this point.
> Source/WebCore/css/CSSParser.cpp:9350
> + if (!data)
You are already asserting data is not null on the line above.
More information about the webkit-reviews
mailing list