[webkit-reviews] review denied: [Bug 88420] Web Inspector: Provide source data for all known rule types in CSSParser, except "keyframe" and "region" : [Attachment 149281] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 88420: Web Inspector: Provide source data for all known rule types in
CSSParser, except "keyframe" and "region"
https://bugs.webkit.org/show_bug.cgi?id=88420

Attachment 149281: Patch
https://bugs.webkit.org/attachment.cgi?id=149281&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149281&action=review


> Source/WebCore/css/CSSGrammar.y:492
> +  | before_import_rule IMPORT_SYM error ';' {

I don't think you need to gather any data for errors. This change should be
reverted.

> Source/WebCore/css/CSSGrammar.y:496
> +  | before_import_rule IMPORT_SYM error invalid_block {

Ditto, should be reverted.

> Source/WebCore/css/CSSGrammar.y:684
> +	   CSSParser* p = static_cast<CSSParser*>(parser);

This should probably be in the end of keyframes action.

> Source/WebCore/css/CSSGrammar.y:685
> +	   if (p->isExtractingSourceData())

I would move this check inside the method.

> Source/WebCore/css/CSSGrammar.y:744
> +    | before_page_rule PAGE_SYM error invalid_block {

Ditto, should be reverted.

> Source/WebCore/css/CSSGrammar.y:748
> +    | before_page_rule PAGE_SYM error ';' {

Ditto, should be reverted.

> Source/WebCore/css/CSSGrammar.y:856
> +    | before_font_face_rule FONT_FACE_SYM error invalid_block {

Ditto, should be reverted.

> Source/WebCore/css/CSSGrammar.y:860
> +    | before_font_face_rule FONT_FACE_SYM error ';' {

Ditto, should be reverted.

> Source/WebCore/css/CSSParser.cpp:1156
> +    RefPtr<CSSRuleSourceData> ruleSourceDataRef = ruleSourceData;

prpRuleSourceData / ruleSourceData?

> Source/WebCore/css/CSSParser.cpp:1175
> +    if (ruleSourceDataRef) {

I would add an assertion that stack size is correct here.

> Source/WebCore/css/CSSParser.cpp:9375
> +	   ASSERT(!m_currentRuleDataStack->isEmpty());

We can probably extract these 4-5 lines to one method.

> Source/WebCore/css/CSSParser.cpp:9681
> +void CSSParser::markAtRuleHeaderStart(CSSRuleSourceData::Type ruleType)

Looks like markStyleRuleHeaderStart and markAtRuleHeaderStart are identical.