[webkit-reviews] review canceled: [Bug 87718] Shader compiler unprepared to make ESSL output when GLES is used : [Attachment 145957] patch

[bugzilla-daemon at webkit.org]

Roland Takacs <rtakacs at inf.u-szeged.hu> has canceled Roland Takacs
<rtakacs at inf.u-szeged.hu>'s request for review:
Bug 87718: Shader compiler unprepared to make ESSL output when GLES is used
https://bugs.webkit.org/show_bug.cgi?id=87718

Attachment 145957: patch
https://bugs.webkit.org/attachment.cgi?id=145957&action=review

------- Additional Comments from Roland Takacs <rtakacs at inf.u-szeged.hu>
If I add a new argument to the ANGLEWebKitBridge constructor, the m_compiler
(member of GraphicsContext3D class) must be initialized with the parameter at
the GraphicsContext3D constructor ( on qt, this located at the
GraphicsContext3DQt.cpp ).

If I would like to initialize the m_compiler (ANGLEWebKitBridge) at the GC3D
constructor, it looks like:

GraphicsContext3D::GraphicsContext3D(....)
   : .....
   , .....
#if (opengles)
   , m_compiler(SH_ESSL_OUTPUT)
#else
   , m_compiler(SH_GLSL_OUTPUT)
#endif
   , ...
   , ...

So I could not initialize the m_compiler runtime (with isGles2Compliant()) only
compiling time. [AFAIK]

Because of this, I would rather add a new member ( m_shaderOutput) to
ANGLEWebKitBridge, and it is initialized at its constructor by macro checking.

Let me know how do you think if it not the best solution. :)