[webkit-reviews] review granted: [Bug 89668] Move CSSWrapShape style resolution from StyleResolver to StyleBuilder : [Attachment 148827] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 89668: Move CSSWrapShape style resolution from StyleResolver to
StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=89668

Attachment 148827: Patch
https://bugs.webkit.org/attachment.cgi?id=148827&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148827&action=review


Looks good. r=me with one change:

> Source/WebCore/css/StyleBuilder.cpp:1782
> +	       else
> +		   setValue(styleResolver->style(),
primitiveValue->getShapeValue());

The previous version of the code had a check for primitiveValue->isShape(), if
we know that this should always be the case, we could put an
ASSERT(primitiveValue->isShape()) here.