[webkit-reviews] review denied: [Bug 89837] [WK2][Qt][EFL] Extract common code from LayerTreeHostQt : [Attachment 149231] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied YoungTaeck Song
<youngtaeck.song at samsung.com>'s request for review:
Bug 89837: [WK2][Qt][EFL] Extract common code from LayerTreeHostQt
https://bugs.webkit.org/show_bug.cgi?id=89837

Attachment 149231: patch
https://bugs.webkit.org/attachment.cgi?id=149231&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149231&action=review


LayerTreeHostWeb doesn't fit with the rest of the names around.
How about we create a LayerTreeCoordinator directory under WebProcess/WebPage,
and also move WebGraphicsLayer under that directory? We should rename
LayerTreeHostProxy to LayerTreeCoordinatorProxy while we're at it.

> Source/WebKit2/WebProcess/WebPage/web/qt/LayerTreeHostQt.h:38
> +class LayerTreeHostQt : public LayerTreeHostWeb {
> +public:
> +    static PassRefPtr<LayerTreeHostQt> create(WebPage*);
> +    virtual ~LayerTreeHostQt();
> +
> +    virtual int64_t directlyCompositedImageKey(WebCore::Image*);
> +
> +private:
> +    explicit LayerTreeHostQt(WebPage*);
> +};

Virtualizing for this seems like an overkill... I'd rather have non-virtual
functions, and implement directlyCompositedImageKey inside a platform-specific
#ifdef.