[webkit-reviews] review granted: [Bug 89423] [EFL] Support screenDepth() functionality. : [Attachment 148254] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jun 24 19:15:42 PDT 2012
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 89423: [EFL] Support screenDepth() functionality.
https://bugs.webkit.org/show_bug.cgi?id=89423
Attachment 148254: Patch
https://bugs.webkit.org/attachment.cgi?id=148254&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148254&action=review
> Source/WebCore/platform/efl/EflScreenUtilities.cpp:139
> + if (!window)
> + return 0;
Is that a good value? depth of 0 ? Why not just return 8 like below?
More information about the webkit-reviews
mailing list