[webkit-reviews] review denied: [Bug 89797] [chromium] Add the workaround of IOSurface-related corruption during readback for Mac OS X 10.6.8 : [Attachment 149149] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 23 23:15:12 PDT 2012


Kenneth Russell <kbr at google.com> has denied Yasuhiro Matsuda
<mazda at chromium.org>'s request for review:
Bug 89797: [chromium] Add the workaround of IOSurface-related corruption during
readback for Mac OS X 10.6.8
https://bugs.webkit.org/show_bug.cgi?id=89797

Attachment 149149: Patch
https://bugs.webkit.org/attachment.cgi?id=149149&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149149&action=review


>> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:1368
>> +	    // On Mac OS X 10.6.8+, calling glReadPixels against an FBO whose
color attachment is an
> 
> do we know that this is broke from 1.6.7 -> 1.6.8?  Should we just do this
unconditionally on mac?

I doubt that that is known for sure. Agree, we should just do this on all OS
versions now -- it's OK to leave the function needsIOSurfaceReadbackWorkaround,
but let's just make it unconditionally return true (IOSurfaces were introduced
in 10.6, so it looks like we need the workaround all the time for now, unless
we can confirm the issue was fixed in 10.8).


More information about the webkit-reviews mailing list