[webkit-reviews] review granted: [Bug 89791] Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch : [Attachment 149136] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 89791: Add support for test_expectations_android.txt for overriding test
expecations on the chromium-android branch
https://bugs.webkit.org/show_bug.cgi?id=89791

Attachment 149136: Patch
https://bugs.webkit.org/attachment.cgi?id=149136&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149136&action=review


> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:221
> +	   return expectations_files

I would've just had:

# FIXME: remove when chromium-android is fully upstreamed.
def expectations_files(self):	
   return super(ChromiumAndroidPort, self).expectations_files() +
[self.path_from_webkit_base(...)]

but this is fine.