[webkit-reviews] review denied: [Bug 89759] [CSSRegions]Change display values that allow regions : [Attachment 149034] patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Andrei Onea <onea at adobe.com>'s
request for review:
Bug 89759: [CSSRegions]Change display values that allow regions
https://bugs.webkit.org/show_bug.cgi?id=89759

Attachment 149034: patch
https://bugs.webkit.org/attachment.cgi?id=149034&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149034&action=review


Are there existing tests for changing the display type dynamically in
javascript? Do we properly re-create the RenderObject in that case?

> Source/WebCore/ChangeLog:9
> +	   Allow only elements with display values of block, inline-block,
> +	   table-cell, table-caption and list-item to become regions.

Can you include a link to the spec here?

> Source/WebCore/rendering/style/RenderStyle.h:1511
> +    { // Only non-replaced block elements can become a region.
> +	   return display() == BLOCK || display() == INLINE_BLOCK
> +	       || display() == TABLE_CELL || display() == TABLE_CAPTION
> +	       || display() == LIST_ITEM;

What about table, box, flexbox, grid and their inline versions?