[webkit-reviews] review granted: [Bug 89785] REGRESSION(r116446): Crash in RenderBoxModelObject::adjustedPositionRelativeToOffsetParent : [Attachment 149119] Proposed fix. NULL-check parent.

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 89785: REGRESSION(r116446): Crash in
RenderBoxModelObject::adjustedPositionRelativeToOffsetParent
https://bugs.webkit.org/show_bug.cgi?id=89785

Attachment 149119: Proposed fix. NULL-check parent.
https://bugs.webkit.org/attachment.cgi?id=149119&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149119&action=review


> LayoutTests/fullscreen/full-screen-crash-offsetLeft.html:16
> +	   if (window.testRunner) {

these four lines are already provided by full-screen-test.js. no need of them
here.

> LayoutTests/fullscreen/full-screen-crash-offsetLeft.html:28
> +	       if (window.testRunner) 

nit: you can just call endTest() function in full-screen-test.js

> LayoutTests/fullscreen/full-screen-crash-offsetLeft.html:37
> +	   if (window.eventSender)

nit: you can use the runKeyDown function if you want.