[webkit-reviews] review granted: [Bug 89625] IndexedDB: Avoid infinite loop if we try to encode -1 for leveldb : [Attachment 148702] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 89625: IndexedDB: Avoid infinite loop if we try to encode -1 for leveldb
https://bugs.webkit.org/show_bug.cgi?id=89625

Attachment 148702: Patch
https://bugs.webkit.org/attachment.cgi?id=148702&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
I think this is OK, but I worry that you're effectively ignoring the logic
error in release builds and it could cascade into other logic errors.  Ideally,
you would abort or throw an exception or something, but that might not be
possible at this point in the code.

Another possibility is to use CRASH() to kill the process in release builds.
That has the downside that the user might lose data, but at least we would get
a stack trace.