[webkit-reviews] review granted: [Bug 88414] [NRWT] XvfbDriver should choose the next free display : [Attachment 149029] proposed fix

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 88414: [NRWT] XvfbDriver should choose the next free display
https://bugs.webkit.org/show_bug.cgi?id=88414

Attachment 149029: proposed fix
https://bugs.webkit.org/attachment.cgi?id=149029&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149029&action=review


the patch basically looks fine with a couple nits ... I'll leave cq? in case
you want to change things.

> Tools/Scripts/webkitpy/layout_tests/port/xvfbdriver.py:53
> +		       _guard_lock_file = self._port._filesystem.join('/tmp',
'WebKitXvfb.lock.%i' % i)

nit: there's no reason to use an underscore in front of the name. I'd probably
just combine lines 53 and 54 ...

> Tools/Scripts/webkitpy/layout_tests/port/xvfbdriver.py:58
> +	   self.display_id = next_free_id()

should this be self._display_id to indicate that it's a private variable?