[webkit-reviews] review granted: [Bug 88268] [chromium] Expose rendering statistics to WebLayerTreeView. : [Attachment 149091] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 14:11:24 PDT 2012


James Robinson <jamesr at chromium.org> has granted Dave Tu <dtu at chromium.org>'s
request for review:
Bug 88268: [chromium] Expose rendering statistics to WebLayerTreeView.
https://bugs.webkit.org/show_bug.cgi?id=88268

Attachment 149091: Patch
https://bugs.webkit.org/attachment.cgi?id=149091&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149091&action=review


R=me

> Source/WebKit/chromium/src/WebLayerTreeView.cpp:39
> +#include "public/WebRenderingStats.h"

nit: should be #include <public/WebRenderingStats.h>

> Source/WebKit/chromium/src/WebViewImpl.cpp:734
> +    if (!isAcceleratedCompositingActive())
> +	   ASSERT_NOT_REACHED();

we'd normally spell this: ASSERT(isAcceleratedCompositingActive());


More information about the webkit-reviews mailing list