[webkit-reviews] review granted: [Bug 89123] JSLock should be per-JSGlobalData : [Attachment 149025] Win

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 89123: JSLock should be per-JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=89123

Attachment 149025: Win
https://bugs.webkit.org/attachment.cgi?id=149025&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149025&action=review


> Source/JavaScriptCore/runtime/JSLock.cpp:42
> +static pthread_mutex_t giantGlobalJSLock = PTHREAD_MUTEX_INITIALIZER;

I'm not sure that 'giant' adds much here, but sure, why not. :o)

> Source/JavaScriptCore/runtime/JSLock.cpp:100
> +    {

Looks like this extra block is redundant, the scope goes to the end of the
function anyway – should be able to remove.

> Source/WebCore/bridge/c/c_class.cpp:51
> +    // FIXME: Should we acquire a JSLock here?

Doesn't look like this code touches JSC, I'd delete this FIXME, looks like this
was just junk code.

If you think there is a real risk, then keep the fixme & file new bugzilla bugs
to track that this should be investigated. (though I think this is unnecessary)


> Source/WebCore/bridge/jni/jsc/JavaClassJSC.cpp:66
> +		   // FIXME: Should we acquire a JSLock here?

Ditto to c_class, delete the FIXME.

> Source/WebCore/bridge/jni/jsc/JavaClassJSC.cpp:82
> +		   // FIXME: Should we acquire a JSLock here?

Ditto to c_class, delete the FIXME.

> Source/WebCore/bridge/jni/jsc/JavaClassJSC.cpp:103
> +    // FIXME: Should we acquire a JSLock here?

Ditto to c_class, delete the FIXME.

> Source/WebCore/bridge/jni/jsc/JavaMethodJSC.cpp:114
> +	   // FIXME: Should we acquire a JSLock here?

Ditto to c_class, delete the FIXME.