[webkit-reviews] review requested: [Bug 89674] Cannot open calendar picker for input type=date using a touch tap gesture if TOUCH_ADJUSTMENT is enabled. : [Attachment 149020] Patch

[bugzilla-daemon at webkit.org]

Kevin Ellis <kevers at chromium.org> has asked  for review:
Bug 89674: Cannot open calendar picker for input type=date using a touch tap
gesture if TOUCH_ADJUSTMENT is enabled.
https://bugs.webkit.org/show_bug.cgi?id=89674

Attachment 149020: Patch
https://bugs.webkit.org/attachment.cgi?id=149020&action=review

------- Additional Comments from Kevin Ellis <kevers at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149020&action=review


>> Source/WebCore/page/EventHandler.cpp:2494
>> +	// handle targetNode being a shadow DOM node (see bug 69556). 
> 
> This is supported in HitTestResult side. The BlackBerry port, for example,
only works with shadow content, if they have a media element (<video> or
<audio>) as ancestor.
> 
> The bug 69556 does not seem related. Maybe wrong bug ID?

Wrong ID.  Corrected to 89556 (Touch adjustment does not target shadow DOM
elements).

>> LayoutTests/touchadjustment/nested-shadow-node.html:37
>> +	function addShadowDom() {
> 
> Dom => DOM

Done.

>> LayoutTests/touchadjustment/nested-shadow-node.html:81
>> +	    var top = touchY - padding/2;
> 
> nit: space before/after "/"

Done.