[webkit-reviews] review granted: [Bug 89775]=?UTF-8?Q?=20RenderText=E2=80=99s=20minimum=20preferred=20width=20is=20incorrect=20when=20soft=20hyphens=20are=20used=20?=: [Attachment 149079] Include hyphen width in minimun preferred width, and ignore soft hyphens when 'hyphens' is 'none'

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 89775: RenderText’s minimum preferred width is incorrect when soft hyphens
are used
https://bugs.webkit.org/show_bug.cgi?id=89775

Attachment 149079: Include hyphen width in minimun preferred width, and ignore
soft hyphens when 'hyphens' is 'none'
https://bugs.webkit.org/attachment.cgi?id=149079&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149079&action=review


> Source/WebCore/rendering/RenderText.cpp:972
> +	   } else if (c == softHyphen && styleToUse->hyphens() != HyphensNone)
{

Maybe add RenderStyle::usesHyphens() to make this easier to read?