[webkit-reviews] review denied: [Bug 89637] [Chromium] keyDown event in JavaScript: event.shiftKey, event.ctrlKey and event.altKey are always false : [Attachment 148988] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Yusuke Sato <yusukes at chromium.org>'s
request for review:
Bug 89637: [Chromium] keyDown event in JavaScript: event.shiftKey,
event.ctrlKey and event.altKey are always false
https://bugs.webkit.org/show_bug.cgi?id=89637

Attachment 148988: Patch
https://bugs.webkit.org/attachment.cgi?id=148988&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148988&action=review


> Source/WebKit/chromium/ChangeLog:8
> +	   This is a Gtk port of http://crrev.com/142209.
> +	   
> +	   Reviewed by NOBODY (OOPS!).

The "Reviewed by..." line goes below the bug link. See the other entries in the
ChangeLog.

> Source/WebKit/chromium/src/gtk/WebInputEventFactory.cpp:277
> +// Normalizes event->state to make it Windows/Mac compatible. Since the way
> +// of setting modifier mask on X is very different than Windows/Mac as shown

> +// in http://crbug.com/127142#c8, the normalization is necessary.

I would move this comment into the ChangeLog.