[webkit-reviews] review granted: [Bug 89745] Add snap to css3-images image-resolution : [Attachment 148975] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted David Barr
<davidbarr at chromium.org>'s request for review:
Bug 89745: Add snap to css3-images image-resolution
https://bugs.webkit.org/show_bug.cgi?id=89745

Attachment 148975: Patch
https://bugs.webkit.org/attachment.cgi?id=148975&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148975&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests; extended
fast/css/image-resolution/image-resolution.html

This is OK, but the test covers a lot of different things.  If it starts to
fail, it'll probably be harder to figure out what exactly is going wrong (800
lines of test!) than if we had a few more focused tests.

> LayoutTests/fast/css/image-resolution/image-resolution.html:43
> +	   else return;

Nit: return on next line.

> LayoutTests/fast/css/image-resolution/image-resolution.html:48
> -	   dppx = Math.floor(dppx);
> +	   dppx = Math.floor(dppx + 0.01);

Is this due to floating point imprecision? Maybe make a mention of this in the
ChangeLog.