[webkit-reviews] review granted: [Bug 89514] Add url to supportsType : [Attachment 149044] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Danilo Cesar Lemes de Paula
<danilo.cesar at collabora.co.uk>'s request for review:
Bug 89514: Add url to supportsType
https://bugs.webkit.org/show_bug.cgi?id=89514

Attachment 149044: Patch
https://bugs.webkit.org/attachment.cgi?id=149044&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149044&action=review


This looks great modulo the two minor issues noted. Thanks!

> Source/WebCore/ChangeLog:15
> +	   for MediaStream needs to know to URL to decide if it's supported or
not.
> +
> +
> +	   * dom/DOMImplementation.cpp:

Minor nit: extra blank line here.

>
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundation
CF.cpp:731
> +    UNUSED_PARAM(url);
> +

Oops, it looks like you forgot to change this one.