[webkit-reviews] review denied: [Bug 89244] Web Inspector: Add data length to resource events on timeline to keep track of the amount of data loaded and the total data length : [Attachment 149027] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Hanna <hanma at rim.com>'s request
for review:
Bug 89244: Web Inspector: Add data length to resource events on timeline to
keep track of the amount of data loaded and the total data length
https://bugs.webkit.org/show_bug.cgi?id=89244

Attachment 149027: Patch
https://bugs.webkit.org/attachment.cgi?id=149027&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149027&action=review


> Source/WebCore/inspector/TimelineRecordFactory.cpp:168
> +    data->setNumber("DataLength", length);

This should be "dataLength" (lowercase first letter). Perhaps it should even be
"encodedDataLength"?

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:530
> +		   if (this.data["DataLength"])

Ditto.