[webkit-reviews] review denied: [Bug 89554] Web Inspector: Having a "Scroll into view" for nodes through web inspector. : [Attachment 149009] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied sam <dsam2912 at gmail.com>'s
request for review:
Bug 89554: Web Inspector: Having a "Scroll into view" for nodes through web
inspector.
https://bugs.webkit.org/show_bug.cgi?id=89554

Attachment 149009: Patch
https://bugs.webkit.org/attachment.cgi?id=149009&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149009&action=review


> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1073
> +	       var expression = "$0.scrollIntoView(true)";

Note that $0 may not necessarily be a DOM node, e.g. it may be last element
selected in a heap profile.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1074
> +	       WebInspector.consoleView.evalInInspectedWindow(expression,
"console", true, false, false, null);

Instead of going through the consoleView, you should be able to get current
selected node and evaluate .scrollIntoView(true) on it using
RuntimeAgent.evaluate