[webkit-reviews] review requested: [Bug 89568] Web Inspector: partially instrument DOM Tree native memory : [Attachment 149004] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 06:10:59 PDT 2012


Alexei Filippov <alexeif at chromium.org> has asked  for review:
Bug 89568: Web Inspector: partially instrument DOM Tree native memory
https://bugs.webkit.org/show_bug.cgi?id=89568

Attachment 149004: Patch
https://bugs.webkit.org/attachment.cgi?id=149004&action=review

------- Additional Comments from Alexei Filippov <alexeif at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149004&action=review


> Source/WebCore/inspector/InspectorMemoryAgent.cpp:390
> +	   for (int i = 0; i < LastTypeEntry; ++i)

nit: 0 -> Other

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:414
> +	   ASSERT(objectType >= 0 && objectType < LastTypeEntry);

nit: 0 -> Other


More information about the webkit-reviews mailing list