[webkit-reviews] review granted: [Bug 89336] [GTK] Add a new webkit2 tests slave bot : [Attachment 148993] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 06:00:42 PDT 2012


Csaba Osztrogonac <ossy at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 89336: [GTK] Add a new webkit2 tests slave bot
https://bugs.webkit.org/show_bug.cgi?id=89336

Attachment 148993: Patch
https://bugs.webkit.org/attachment.cgi?id=148993&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148993&action=review


LGTM, r=me. Please land it when most of the bots are IDLE to avoid problems
with master restart.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:143
> +			 "triggers": ["gtk-linux-64-release-tests-wk2"],
"slavenames": ["gtk-linux-slave-2"]

Just a nit: Could you put them into two lines as the other builders does?


More information about the webkit-reviews mailing list