[webkit-reviews] review canceled: [Bug 43819] MathML: nested square root symbols have varying descenders : [Attachment 147950] Patch

[bugzilla-daemon at webkit.org]

Dave Barton <dbarton at mathscribe.com> has canceled Dave Barton
<dbarton at mathscribe.com>'s request for review:
Bug 43819: MathML: nested square root symbols have varying descenders
https://bugs.webkit.org/show_bug.cgi?id=43819

Attachment 147950: Patch
https://bugs.webkit.org/attachment.cgi?id=147950&action=review

------- Additional Comments from Dave Barton <dbarton at mathscribe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147950&action=review


Thanks as always for the review, Julien!

Sorry this patch looks so big, but hopefully it will be the last one to
rebaseline all the MathML tests for a while.

>> Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp:149
>> +	LayoutUnit baseWrapperBaseline =
toRenderBox(firstChild())->firstLineBoxBaseline();
> 
> You can use: baseWrapper->firstLineBoxBaseline()

That doesn't compile:
RenderBlock.h:425: error: 'virtual WebCore::LayoutUnit
WebCore::RenderBlock::firstLineBoxBaseline() const' is protected

>> Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:158
>> +	    /* fall through */
> 
> For one line comment, WebKit uses // not /* */
> 
> This is very weird that over uses the under computation. I would have
expected the other around for UnderOver.

To compute the UnderOver baseline, one must use the base's baseline in any
case, plus the overscript's height if it exists.