[webkit-reviews] review denied: [Bug 89735] Web Inspector: Provide context menu 'Delete all watch expressions.' : [Attachment 148959] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 89735: Web Inspector: Provide context menu 'Delete all watch expressions.'
https://bugs.webkit.org/show_bug.cgi?id=89735

Attachment 148959: Patch
https://bugs.webkit.org/attachment.cgi?id=148959&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148959&action=review


Rahul Tiwari, I would kindly ask that you do not r+ inspector-related changes.
Reviewership means that you understand the code you are reviewing.

> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:258
> +    deleteAllExpressions: function()

This should be declared private.

> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:261
> +	       delete this.watchExpressions[i];

What are you trying to do here? Clearing the array?

> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:274
> +    expressionCount: function()

should be private