[webkit-reviews] review denied: [Bug 89461] Web Inspector: Design WebSockets panel : [Attachment 148774] DataGrid

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Nikita Vasilyev
<me at elv1s.ru>'s request for review:
Bug 89461: Web Inspector: Design WebSockets panel
https://bugs.webkit.org/show_bug.cgi?id=89461

Attachment 148774: DataGrid
https://bugs.webkit.org/attachment.cgi?id=148774&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148774&action=review


r- for the missing time column, otherwise looks good.

> Source/WebCore/inspector/front-end/NetworkItemView.js:46
> +	   this.appendTab("webSocketFrames", WebInspector.UIString("WebSocket
Frames"), frameView);

I actually think that "Frames" should be sufficient. You should also do
"return;" after this line since no further views apply to sockets.

> Source/WebCore/inspector/front-end/ResourceWebSocketFrameView.js:30
> +    var dataGrid = new WebInspector.DataGrid([

This is a nice refactoring, thank you!

> Source/WebCore/inspector/front-end/networkPanel.css:308
> +    border-bottom: 1px solid #EEE;

we typically use rgb() notation for colors.